Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump foyer #13029

Merged
merged 1 commit into from
Oct 24, 2023
Merged

chore: bump foyer #13029

merged 1 commit into from
Oct 24, 2023

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Oct 24, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Bump foyer to a version before toolchain bump to fix config changes issue.

Later foyer will follow the rust version rules to avoid breaking changes within the same version.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: MrCroxx <[email protected]>
@MrCroxx MrCroxx requested a review from a team as a code owner October 24, 2023 09:59
@TennyZhuang TennyZhuang enabled auto-merge October 24, 2023 10:01
@MrCroxx MrCroxx requested a review from TennyZhuang October 24, 2023 10:01
@TennyZhuang TennyZhuang added this pull request to the merge queue Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #13029 (cbbce5a) into main (e64543f) will increase coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #13029      +/-   ##
==========================================
+ Coverage   68.63%   68.70%   +0.06%     
==========================================
  Files        1495     1495              
  Lines      251135   251136       +1     
==========================================
+ Hits       172369   172535     +166     
+ Misses      78766    78601     -165     
Flag Coverage Δ
rust 68.70% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/storage/src/hummock/file_cache/store.rs 40.49% <0.00%> (-0.17%) ⬇️

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 447e142 Oct 24, 2023
9 of 10 checks passed
@TennyZhuang TennyZhuang deleted the xx/bump-foyer branch October 24, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants