fix: openssl is compiled twice, once not vendored in linux #13001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s broken since the workspace-hack change (#12961). Openssl-sys is compiled twice on Linux, because features are not unified. The one for build-dependency doesn’t have openssl-sys feature. It’s depended by tls-native, which is depended by sql-x, which is build-dependency in workspace-hack. (Since we didn't configure hakari to unify target os-specific dependencies, hakari unified it only *partialy*, and this cause them unnecessarily compiled twice.) Simply put, it’s now a build-dependency so - Feature is not unified. This can be fixed easily and is done in this PR. - It will be compiled twice in release mode. Unless #12362, but it’s broken. Not a large problem(? Well, I’m not sure But it has been so). Just slower… This only happens on linux, but not mac, because native-tls works differently for different os. Temporary workaround this by manually unify feature in workspace-config to unblock daily pipeline and stuff. Later, we might delete [build-dependencies] for docker/release. Or completely get rid of workspace-hack. TLDR: After this change, on Linux openssl is compiled once in debug mode, and still twice in release mode. Both once on mac.
Codecov Report
@@ Coverage Diff @@
## main #13001 +/- ##
=======================================
Coverage 68.75% 68.76%
=======================================
Files 1496 1496
Lines 250409 250409
=======================================
+ Hits 172179 172198 +19
+ Misses 78230 78211 -19
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
docker build passed |
BugenZhao
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s broken since the workspace-hack change (#12961).
Openssl-sys is compiled twice on Linux, because features are not unified.
The one for build-dependency doesn’t have openssl-sys feature. It’s depended by tls-native, which is depended by sql-x, which is build-dependency in workspace-hack. (Since we didn't configure hakari to unify target os-specific dependencies, hakari unified it only partialy, and this cause them unnecessarily compiled twice.)
Simply put, it’s now a build-dependency so
This only happens on linux, but not mac, because native-tls works differently for different os.
Temporary workaround this by manually unify feature in workspace-config to unblock daily pipeline and stuff. Later, we might delete [build-dependencies] for docker/release. Or completely get rid of workspace-hack.
TLDR: After this change, on Linux openssl is compiled once in debug mode, and still twice in release mode. Both once on mac.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.