-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert(ci): e2e timeout 15 -> 17 #12985
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12985 +/- ##
==========================================
+ Coverage 68.78% 68.79% +0.01%
==========================================
Files 1495 1495
Lines 250092 250092
==========================================
+ Hits 172014 172052 +38
+ Misses 78078 78040 -38
Flags with carried forward coverage won't be shown. Click here to find out more. see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8m40s again 😂 |
sleep 30s | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hzxa21 Are the sleeps necessary given we already enabled implicit flush?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
table size is propagated to frontend through async notification. I think a sleep is still needed since a successful flush doesn't mean the notification is received by frontend. But 30s sleep seems too long. We can make it 3s I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
CI e2e timeout was bumped from 15m to 17m in #12858, on suspicion that there was perf regression #12825. It ran consistently slower (batch taking 8m50s) during 2023-10-20T15:06Z - 2023-10-21T07:27Z but came back to 7m30s after that.
https://buildkite.com/risingwavelabs/pull-request/builds/33837
https://buildkite.com/risingwavelabs/pull-request/builds/33835
https://buildkite.com/risingwavelabs/pull-request/builds/33834
Ideally there should be no such ci performance fluctuation. Still no clue what happend.
At the same time started an attempt to reduce test time #12984
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.