Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(ci): e2e timeout 15 -> 17 #12985

Merged
merged 3 commits into from
Oct 23, 2023
Merged

revert(ci): e2e timeout 15 -> 17 #12985

merged 3 commits into from
Oct 23, 2023

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Oct 21, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

CI e2e timeout was bumped from 15m to 17m in #12858, on suspicion that there was perf regression #12825. It ran consistently slower (batch taking 8m50s) during 2023-10-20T15:06Z - 2023-10-21T07:27Z but came back to 7m30s after that.

https://buildkite.com/risingwavelabs/pull-request/builds/33837
https://buildkite.com/risingwavelabs/pull-request/builds/33835
https://buildkite.com/risingwavelabs/pull-request/builds/33834

Ideally there should be no such ci performance fluctuation. Still no clue what happend.

At the same time started an attempt to reduce test time #12984

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #12985 (9e4050b) into main (19643ad) will increase coverage by 0.01%.
Report is 9 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #12985      +/-   ##
==========================================
+ Coverage   68.78%   68.79%   +0.01%     
==========================================
  Files        1495     1495              
  Lines      250092   250092              
==========================================
+ Hits       172014   172052      +38     
+ Misses      78078    78040      -38     
Flag Coverage Δ
rust 68.79% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangjinwu xiangjinwu marked this pull request as ready for review October 22, 2023 03:10
@xiangjinwu
Copy link
Contributor Author

8m40s again 😂

@xxchan
Copy link
Member

xxchan commented Oct 22, 2023

It seems there has been fluctuation for a while, but it's not clear what's wrong. 😟 Maybe we need more fine-grained monitoring for CI to know regression better.

image

Comment on lines 7 to 8
sleep 30s

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hzxa21 Are the sleeps necessary given we already enabled implicit flush?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table size is propagated to frontend through async notification. I think a sleep is still needed since a successful flush doesn't mean the notification is received by frontend. But 30s sleep seems too long. We can make it 3s I think.

Copy link
Contributor

@huangjw806 huangjw806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xiangjinwu xiangjinwu enabled auto-merge October 23, 2023 07:28
@xiangjinwu xiangjinwu added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit 8f981f3 Oct 23, 2023
6 of 7 checks passed
@xiangjinwu xiangjinwu deleted the ci-revert-e2e-timeout branch October 23, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants