-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove meta's dependency on sink implementation to reduce compile time #12981
Closed
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
21a5201
refactor: remove meta's dependency on sink implementation to reduce c…
wenym1 2151b86
Merge branch 'main' into yiming/separate-connector-crate
wenym1 0b4f288
Update src/connector/connector_common/src/kafka/mod.rs
wenym1 5dc5f1f
update cargo lock
wenym1 62f463b
add files
wenym1 86886ff
Update src/connector/sink_impl/src/lib.rs
wenym1 0028edc
Merge branch 'main' into yiming/separate-connector-crate
wenym1 fc2a51f
merge connector_common and connector
wenym1 69f74fd
use ctor to set function pointer
wenym1 7402d64
add sink impl to meta dev dependency
wenym1 a6a4ad2
fix madsim compile
wenym1 406173d
import sink impl to enable function inject
wenym1 577c5cb
Fix "cargo-hakari"
wenym1 31f6024
fmt
wenym1 119cafb
remove unused dependencies
wenym1 3471bbe
Merge branch 'main' into yiming/separate-connector-crate
wenym1 56c82f2
remove frontend's dependency on sink impl and resolve comment
wenym1 4a0ec07
Merge branch 'main' into yiming/separate-connector-crate
wenym1 e9c1154
fix unit test
wenym1 da92934
Merge branch 'main' into yiming/separate-connector-crate
wenym1 5dd6c01
Merge branch 'main' into yiming/separate-connector-crate
xxchan a9535c2
fix
xxchan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
[package] | ||
name = "risingwave_sink_impl" | ||
version = { workspace = true } | ||
edition = { workspace = true } | ||
homepage = { workspace = true } | ||
keywords = { workspace = true } | ||
license = { workspace = true } | ||
repository = { workspace = true } | ||
|
||
[package.metadata.cargo-machete] | ||
ignored = ["workspace-hack"] | ||
|
||
[package.metadata.cargo-udeps.ignore] | ||
normal = ["workspace-hack"] | ||
|
||
[dependencies] | ||
anyhow = "1" | ||
arrow-array = { workspace = true } | ||
arrow-schema = { workspace = true } | ||
async-nats = "0.32" | ||
async-trait = "0.1" | ||
aws-sdk-kinesis = { workspace = true } | ||
base64 = "0.21" | ||
bytes = { version = "1", features = ["serde"] } | ||
clickhouse = { git = "https://github.com/risingwavelabs/clickhouse.rs", rev = "622501c1c98c80baaf578c716d6903dde947804e", features = [ | ||
"time", | ||
] } | ||
ctor = "0.2" | ||
futures = { version = "0.3", default-features = false, features = ["alloc"] } | ||
gcp-bigquery-client = "0.18.0" | ||
http = "0.2" | ||
hyper = { version = "0.14", features = [ | ||
"client", | ||
"tcp", | ||
"http1", | ||
"http2", | ||
"stream", | ||
] } | ||
hyper-tls = "0.5" | ||
icelake = { workspace = true } | ||
itertools = "0.11" | ||
jni = { version = "0.21.1", features = ["invocation"] } | ||
maplit = "1.0.2" | ||
mysql_async = { version = "0.33", default-features = false, features = [ | ||
"default", | ||
] } | ||
mysql_common = { version = "0.31", default-features = false, features = [ | ||
"chrono", | ||
] } | ||
parking_lot = "0.12" | ||
prost = { version = "0.12", features = ["no-recursion-limit"] } | ||
pulsar = { version = "6.0", default-features = false, features = [ | ||
"tokio-runtime", | ||
"telemetry", | ||
"auth-oauth2", | ||
] } | ||
rdkafka = { workspace = true, features = [ | ||
"cmake-build", | ||
# "ssl", | ||
# FIXME: temporary workaround before we find an ideal solution. | ||
# See why it's needed and why it's not ideal in https://github.com/risingwavelabs/risingwave/issues/9852 | ||
"ssl-vendored", | ||
"gssapi", | ||
"zstd", | ||
] } | ||
redis = { version = "0.24.0", features = ["aio", "tokio-comp", "async-std-comp"] } | ||
regex = "1.4" | ||
risingwave_common = { workspace = true } | ||
risingwave_connector = { workspace = true } | ||
risingwave_jni_core = { workspace = true } | ||
risingwave_pb = { workspace = true } | ||
risingwave_rpc_client = { workspace = true } | ||
risingwave_sqlparser = { workspace = true } | ||
serde = { version = "1", features = ["derive", "rc"] } | ||
serde_derive = "1" | ||
serde_json = "1" | ||
serde_with = { version = "3", features = ["json"] } | ||
strum = "0.25" | ||
strum_macros = "0.25" | ||
time = "0.3.28" | ||
tokio = { version = "0.2", package = "madsim-tokio", features = [ | ||
"rt", | ||
"rt-multi-thread", | ||
"sync", | ||
"macros", | ||
"time", | ||
"signal", | ||
"fs", | ||
] } | ||
tokio-retry = "0.3" | ||
tokio-stream = "0.1" | ||
tracing = "0.1" | ||
url = "2" | ||
with_options = { path = "../../utils/with_options" } | ||
yup-oauth2 = "8.3" | ||
|
||
[target.'cfg(not(madsim))'.dependencies] | ||
workspace-hack = { path = "../../workspace-hack" } | ||
|
||
[dev-dependencies] | ||
criterion = { workspace = true, features = ["async_tokio", "async"] } | ||
rand = "0.8" | ||
tempfile = "3" | ||
tracing-test = "0.2" | ||
|
||
[build-dependencies] | ||
prost-build = "0.12" | ||
|
||
[lints] | ||
workspace = true |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can you help prune the dependencies here (and the connector crate) (via
cargo machete
orcargo udeps
)?Not a requirement since it won't have negative affects immediately. I can also do it in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed some unused deps with the help of cargo-machete. Thanks for suggesting the tools!