Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ctl): support rebuild table stats with approximate value #12946

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Oct 18, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Close #12927

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang28 zwang28 enabled auto-merge October 18, 2023 09:01
@zwang28 zwang28 added this pull request to the merge queue Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #12946 (a6d7d10) into main (0908740) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 81.29%.

@@            Coverage Diff             @@
##             main   #12946      +/-   ##
==========================================
+ Coverage   68.60%   68.63%   +0.02%     
==========================================
  Files        1496     1496              
  Lines      249577   249716     +139     
==========================================
+ Hits       171232   171382     +150     
+ Misses      78345    78334      -11     
Flag Coverage Δ
rust 68.63% <81.29%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/ctl/src/lib.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/hummock/list_version.rs 0.00% <0.00%> (ø)
src/rpc_client/src/meta_client.rs 4.08% <0.00%> (-0.02%) ⬇️
src/meta/service/src/hummock_service.rs 2.98% <0.00%> (-0.05%) ⬇️
src/meta/src/hummock/manager/versioning.rs 77.13% <93.38%> (+6.30%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 878ebac Oct 18, 2023
10 of 11 checks passed
@zwang28 zwang28 deleted the wangzheng/rebuild_table_stats branch October 18, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for table stats rebuild
2 participants