Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't count file cache buffer pool size if disabled #12941

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Oct 18, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Don't count file cache buffer pool size if disabled.

close #12943

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx MrCroxx requested a review from hzxa21 October 18, 2023 07:48
@MrCroxx MrCroxx self-assigned this Oct 18, 2023
@github-actions github-actions bot added the type/fix Bug fix label Oct 18, 2023
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #12941 (0de820f) into main (01ed55b) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #12941      +/-   ##
==========================================
+ Coverage   69.17%   69.19%   +0.01%     
==========================================
  Files        1493     1493              
  Lines      246499   246501       +2     
==========================================
+ Hits       170521   170560      +39     
+ Misses      75978    75941      -37     
Flag Coverage Δ
rust 69.19% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/compute/src/memory_management/mod.rs 83.43% <100.00%> (+0.19%) ⬆️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 52f4c63 Oct 18, 2023
16 of 17 checks passed
@MrCroxx MrCroxx deleted the xx/mem branch October 18, 2023 08:36
MrCroxx added a commit that referenced this pull request Oct 18, 2023
MrCroxx added a commit that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: mistakenly include file cache buffer pool size in memory calculation
3 participants