Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(expr): allow defining context visibility using restricted relative path #12919

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

TennyZhuang
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@TennyZhuang TennyZhuang changed the title refactor(expr): allow defining context visibility using restricted path refactor(expr): allow defining context visibility using restricted relative path Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #12919 (89b6808) into main (35f77c6) will increase coverage by 0.00%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #12919   +/-   ##
=======================================
  Coverage   69.19%   69.19%           
=======================================
  Files        1493     1493           
  Lines      246278   246334   +56     
=======================================
+ Hits       170404   170460   +56     
  Misses      75874    75874           
Flag Coverage Δ
rust 69.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/expr/macro/src/context.rs 90.78% <100.00%> (+0.18%) ⬆️
src/expr/macro/src/utils.rs 100.00% <100.00%> (ø)
src/frontend/src/expr/function_impl/context.rs 83.33% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit c256098 Oct 17, 2023
11 of 12 checks passed
@wangrunji0408 wangrunji0408 deleted the fix-define-context-vis branch October 17, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants