Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cherry pick #12524 and #12840 to v1.3-rc #12888

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Oct 16, 2023

Fix #12883. #12524 is a dependency of #12840.

@stdrc stdrc changed the title cherry pick #12524 and #12840 to v1.3-rc refactor: cherry pick #12524 and #12840 to v1.3-rc Oct 16, 2023
@stdrc stdrc requested review from lmatz, xxchan and st1page October 16, 2023 16:35
@stdrc stdrc enabled auto-merge (squash) October 16, 2023 16:36
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v1.3-rc@cab8135). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             v1.3-rc   #12888   +/-   ##
==========================================
  Coverage           ?   69.49%           
==========================================
  Files              ?     1474           
  Lines              ?   242737           
  Branches           ?        0           
==========================================
  Hits               ?   168698           
  Misses             ?    74039           
  Partials           ?        0           
Flag Coverage Δ
rust 69.49% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stdrc stdrc merged commit 98512f0 into v1.3-rc Oct 17, 2023
10 of 12 checks passed
@stdrc stdrc deleted the rc/cp-12524-12840-to-v1.3 branch October 17, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants