Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix level score of base level #12875

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Oct 16, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix level score of base level. BaseLevelCompaction score must higher than IntraCompaction

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@Li0k Li0k requested a review from Little-Wallace October 16, 2023 10:17
@github-actions github-actions bot added the type/fix Bug fix label Oct 16, 2023
@Li0k Li0k requested a review from zwang28 October 16, 2023 10:21
Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Li0k Li0k enabled auto-merge October 16, 2023 12:10
@Li0k Li0k added this pull request to the merge queue Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #12875 (8fbdc14) into main (1f151cd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #12875      +/-   ##
==========================================
+ Coverage   69.18%   69.22%   +0.03%     
==========================================
  Files        1490     1490              
  Lines      246047   246047              
==========================================
+ Hits       170235   170316      +81     
+ Misses      75812    75731      -81     
Flag Coverage Δ
rust 69.22% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../src/hummock/compaction/selector/level_selector.rs 98.69% <100.00%> (ø)

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 41967d4 Oct 17, 2023
6 of 7 checks passed
@Li0k Li0k deleted the li0k/storage_fix_level_score_of_base branch October 17, 2023 08:34
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
huangjw806 pushed a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants