Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlsmith): ignore ExprError with invalid parameter #12874

Closed
wants to merge 1 commit into from
Closed

fix(sqlsmith): ignore ExprError with invalid parameter #12874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/tests/sqlsmith/src/validation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ fn is_overlay_start_error(db_error: &str) -> bool {
db_error.contains("Invalid parameter start") && db_error.contains("is not positive")
}

/// Unrecognized encoding
/// `decode('8mmqFAxAHQ', 'tTAmH8WncR')`
fn is_encdec_format_error(db_error: &str) -> bool {
db_error.contains("Invalid parameter format: unrecognized encoding")
}

/// Broken channel error
fn is_broken_channel_error(db_error: &str) -> bool {
db_error.contains("failed to finish command: channel closed")
Expand Down Expand Up @@ -114,6 +120,7 @@ pub fn is_permissible_error(db_error: &str) -> bool {
|| is_numeric_overflow_error(db_error)
|| is_neg_substr_error(db_error)
|| is_overlay_start_error(db_error)
|| is_encdec_format_error(db_error)
|| is_broken_channel_error(db_error)
|| is_neg_exp_error(db_error)
}