Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd_all): provide common options config-path and prometheus-listen-addr #12867

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Oct 16, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Closes #12851.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #12867 (6a98e07) into main (e1bdf78) will increase coverage by 0.02%.
Report is 17 commits behind head on main.
The diff coverage is 81.33%.

@@            Coverage Diff             @@
##             main   #12867      +/-   ##
==========================================
+ Coverage   69.06%   69.09%   +0.02%     
==========================================
  Files        1487     1487              
  Lines      244705   244782      +77     
==========================================
+ Hits       169012   169127     +115     
+ Misses      75693    75655      -38     
Flag Coverage Δ
rust 69.09% <81.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/cmd_all/src/common.rs 21.42% <ø> (+21.42%) ⬆️
src/cmd_all/src/standalone.rs 77.03% <81.33%> (+28.54%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kwannoel kwannoel added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit d2ec83c Oct 17, 2023
6 of 7 checks passed
@kwannoel kwannoel deleted the kwannoel/unify branch October 17, 2023 05:57
@arkbriar
Copy link
Contributor

Will the components conflict when listening on the same address? Is there a test to guarantee that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify common options for standalone-mode
3 participants