Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: file cache receives Buf and BufMut api #12863

Closed
wants to merge 3 commits into from
Closed

refactor: file cache receives Buf and BufMut api #12863

wants to merge 3 commits into from

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Oct 16, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

File cache receives Buf and BufMut api to support non-continuous buffer in future.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx MrCroxx requested a review from wangrunji0408 October 16, 2023 06:53
@MrCroxx MrCroxx self-assigned this Oct 16, 2023
@MrCroxx MrCroxx requested a review from a team as a code owner October 16, 2023 06:53
@MrCroxx MrCroxx enabled auto-merge October 16, 2023 07:03
@MrCroxx MrCroxx added this pull request to the merge queue Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #12863 (203248e) into main (e1bdf78) will increase coverage by 0.06%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##             main   #12863      +/-   ##
==========================================
+ Coverage   69.06%   69.12%   +0.06%     
==========================================
  Files        1487     1487              
  Lines      244705   244707       +2     
==========================================
+ Hits       169012   169165     +153     
+ Misses      75693    75542     -151     
Flag Coverage Δ
rust 69.12% <27.27%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/storage/src/hummock/file_cache/store.rs 40.32% <27.27%> (-0.34%) ⬇️

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MrCroxx MrCroxx removed this pull request from the merge queue due to a manual request Oct 16, 2023
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Oct 19, 2023

Trying another way to solve alloaction tail latency, close.

@MrCroxx MrCroxx closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants