Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimizer): optimize join stream key #12831

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #12831 (3fd04e7) into main (0364aff) will decrease coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is 95.12%.

@@            Coverage Diff             @@
##             main   #12831      +/-   ##
==========================================
- Coverage   69.25%   69.25%   -0.01%     
==========================================
  Files        1482     1482              
  Lines      243925   243925              
==========================================
- Hits       168936   168925      -11     
- Misses      74989    75000      +11     
Flag Coverage Δ
rust 69.25% <95.12%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/frontend/src/optimizer/plan_node/generic/join.rs 94.97% <95.12%> (-0.28%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @chenzl25 I pushed 2 commits, one is to refactor the code structure by removing the and_then, another one is to add comments, PTAL before merging. Thanks!

@chenzl25 chenzl25 added this pull request to the merge queue Oct 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 13, 2023
@fuyufjh fuyufjh added this pull request to the merge queue Oct 14, 2023
Merged via the queue into main with commit 387d251 Oct 14, 2023
6 of 7 checks passed
@fuyufjh fuyufjh deleted the dylan/optimize_join_stream_key branch October 14, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimizer: Improve stream key derivation for stream join
2 participants