Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(streaming): assert all states finished, or all not finished for backfill #12767

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Oct 11, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

There should not be a mix of finished / unfinished states. If some partitions are unfinished, on recovery the stream job will be cleaned. But if we scale in after finishing / reschedule the actors in some way to merge partitions, perhaps the current_pos could be different.

Follow up: #12768

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel changed the title fix(backfill): assert all states finished, or all not finished fix(streaming): assert all states finished, or all not finished for backfill Oct 11, 2023
@github-actions github-actions bot added the type/fix Bug fix label Oct 11, 2023
@kwannoel kwannoel requested review from chenzl25 and zwang28 October 11, 2023 05:54
@kwannoel kwannoel enabled auto-merge October 11, 2023 05:59
@kwannoel kwannoel added this pull request to the merge queue Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #12767 (e752660) into main (4ce28cd) will increase coverage by 0.00%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #12767   +/-   ##
=======================================
  Coverage   69.26%   69.26%           
=======================================
  Files        1480     1480           
  Lines      243551   243551           
=======================================
+ Hits       168700   168701    +1     
+ Misses      74851    74850    -1     
Flag Coverage Δ
rust 69.26% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tream/src/executor/backfill/no_shuffle_backfill.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 88ffd82 Oct 11, 2023
24 of 25 checks passed
@kwannoel kwannoel deleted the kwannoel/fix-scale-in branch October 11, 2023 08:21
kwannoel added a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants