Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cast function date #12738

Merged
merged 2 commits into from
Oct 10, 2023
Merged

feat: support cast function date #12738

merged 2 commits into from
Oct 10, 2023

Conversation

jetjinser
Copy link
Contributor

@jetjinser jetjinser commented Oct 10, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

resolve #12688.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

@jetjinser jetjinser requested a review from xiangjinwu October 10, 2023 12:09
@jetjinser jetjinser changed the title feat(expr): support cast function date feat: support cast function date Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #12738 (166d085) into main (7113abd) will decrease coverage by 0.07%.
Report is 7 commits behind head on main.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main   #12738      +/-   ##
==========================================
- Coverage   69.45%   69.38%   -0.07%     
==========================================
  Files        1472     1472              
  Lines      242069   242075       +6     
==========================================
- Hits       168126   167968     -158     
- Misses      73943    74107     +164     
Flag Coverage Δ
rust 69.38% <83.33%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/frontend/src/binder/expr/function.rs 78.36% <83.33%> (+0.02%) ⬆️

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/frontend/src/binder/expr/function.rs Outdated Show resolved Hide resolved
src/frontend/src/binder/expr/function.rs Outdated Show resolved Hide resolved
@jetjinser jetjinser added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit 88a8a37 Oct 10, 2023
6 of 7 checks passed
@jetjinser jetjinser deleted the jinser/support-date-fn branch October 10, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(expr): support function date
2 participants