Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pulsar iceberg table reader #12735

Merged
merged 2 commits into from
Oct 26, 2023
Merged

feat: Add pulsar iceberg table reader #12735

merged 2 commits into from
Oct 26, 2023

Conversation

liurenjie1024
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Close #12563

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@liurenjie1024 liurenjie1024 requested a review from a team as a code owner October 10, 2023 10:21
@liurenjie1024 liurenjie1024 marked this pull request as draft October 10, 2023 11:44
@liurenjie1024 liurenjie1024 marked this pull request as ready for review October 18, 2023 03:35
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #12735 (bc467c9) into main (efdf3c9) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #12735      +/-   ##
==========================================
- Coverage   68.40%   68.25%   -0.16%     
==========================================
  Files        1498     1498              
  Lines      252154   252393     +239     
==========================================
- Hits       172490   172263     -227     
- Misses      79664    80130     +466     
Flag Coverage Δ
rust 68.25% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/connector/src/aws_utils.rs 0.00% <ø> (ø)
src/connector/src/error.rs 0.00% <ø> (ø)
src/connector/src/source/pulsar/mod.rs 0.00% <ø> (ø)
src/connector/src/source/pulsar/topic.rs 66.21% <0.00%> (-2.80%) ⬇️
src/connector/src/source/pulsar/source/reader.rs 0.00% <0.00%> (ø)

... and 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with these. Just some general comments.

src/connector/src/source/base.rs Outdated Show resolved Hide resolved
src/connector/src/source/pulsar/source/reader.rs Outdated Show resolved Hide resolved
src/connector/src/source/pulsar/source/reader.rs Outdated Show resolved Hide resolved
src/connector/src/source/pulsar/source/reader.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@liurenjie1024
Copy link
Contributor Author

cc @xxchan Any other problem?

@liurenjie1024 liurenjie1024 added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit e74b32d Oct 26, 2023
7 of 9 checks passed
@liurenjie1024 liurenjie1024 deleted the renjie/MY-13 branch October 26, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking: Pulsar/iceberg support.
3 participants