-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): define model V2 for hummock metadata #12674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 4248 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1877 | 7 | 2364 | 0 |
Click to see the invalid file list
- src/meta/src/model_v2/compaction_config.rs
- src/meta/src/model_v2/compaction_status.rs
- src/meta/src/model_v2/compaction_task.rs
- src/meta/src/model_v2/hummock_pinned_snapshot.rs
- src/meta/src/model_v2/hummock_pinned_version.rs
- src/meta/src/model_v2/hummock_version_delta.rs
- src/meta/src/model_v2/hummock_version_stats.rs
ea7b6a8
to
c0699f6
Compare
Codecov Report
@@ Coverage Diff @@
## main #12674 +/- ##
=======================================
Coverage ? 69.43%
=======================================
Files ? 1477
Lines ? 241708
Branches ? 0
=======================================
Hits ? 167819
Misses ? 73889
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
May have to fall back to relation with exact 2 fields (key and value) in order to reuse BTreeMapTransaction to the most 😅 . |
I was wrong. Actually BTreeMapTransaction can be reused effortlessly. This PR is ready for review. @yezizp2012 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR defines sql backend model for hummock like #12454.
In addition, as
HummockVersion
is no longer stored in meta store, obsolete code is also removed in this PR.Controllers will be added in subsequent PR.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.