Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): define model V2 for hummock metadata #12674

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Oct 8, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR defines sql backend model for hummock like #12454.
In addition, as HummockVersion is no longer stored in meta store, obsolete code is also removed in this PR.

Controllers will be added in subsequent PR.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 4248 files.

Valid Invalid Ignored Fixed
1877 7 2364 0
Click to see the invalid file list
  • src/meta/src/model_v2/compaction_config.rs
  • src/meta/src/model_v2/compaction_status.rs
  • src/meta/src/model_v2/compaction_task.rs
  • src/meta/src/model_v2/hummock_pinned_snapshot.rs
  • src/meta/src/model_v2/hummock_pinned_version.rs
  • src/meta/src/model_v2/hummock_version_delta.rs
  • src/meta/src/model_v2/hummock_version_stats.rs

src/meta/src/model_v2/compaction_config.rs Outdated Show resolved Hide resolved
src/meta/src/model_v2/compaction_status.rs Outdated Show resolved Hide resolved
src/meta/src/model_v2/compaction_task.rs Outdated Show resolved Hide resolved
src/meta/src/model_v2/hummock_pinned_snapshot.rs Outdated Show resolved Hide resolved
src/meta/src/model_v2/hummock_pinned_version.rs Outdated Show resolved Hide resolved
src/meta/src/model_v2/hummock_version_delta.rs Outdated Show resolved Hide resolved
src/meta/src/model_v2/hummock_version_stats.rs Outdated Show resolved Hide resolved
@zwang28 zwang28 force-pushed the wangzheng/sql_meta_hummock_model branch from ea7b6a8 to c0699f6 Compare October 8, 2023 06:54
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@848b0a1). Click here to learn what that means.
Report is 9 commits behind head on main.
The diff coverage is 88.29%.

@@           Coverage Diff           @@
##             main   #12674   +/-   ##
=======================================
  Coverage        ?   69.43%           
=======================================
  Files           ?     1477           
  Lines           ?   241708           
  Branches        ?        0           
=======================================
  Hits            ?   167819           
  Misses          ?    73889           
  Partials        ?        0           
Flag Coverage Δ
rust 69.43% <88.29%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/src/system_param/mod.rs 84.13% <ø> (ø)
...c/meta/src/backup_restore/meta_snapshot_builder.rs 87.84% <ø> (ø)
src/meta/src/backup_restore/restore.rs 85.68% <100.00%> (ø)
src/meta/src/model_v2/migration/src/lib.rs 100.00% <100.00%> (ø)
src/meta/src/model_v2/mod.rs 0.00% <ø> (ø)
src/meta/src/model_v2/compaction_config.rs 0.00% <0.00%> (ø)
src/meta/src/model_v2/compaction_status.rs 0.00% <0.00%> (ø)
src/meta/src/model_v2/compaction_task.rs 0.00% <0.00%> (ø)
src/meta/src/model_v2/hummock_pinned_snapshot.rs 0.00% <0.00%> (ø)
src/meta/src/model_v2/hummock_pinned_version.rs 0.00% <0.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zwang28 zwang28 requested a review from Little-Wallace October 8, 2023 07:37
@zwang28
Copy link
Contributor Author

zwang28 commented Oct 8, 2023

May have to fall back to relation with exact 2 fields (key and value) in order to reuse BTreeMapTransaction to the most 😅 .

@zwang28
Copy link
Contributor Author

zwang28 commented Oct 10, 2023

May have to fall back to relation with exact 2 fields (key and value) in order to reuse BTreeMapTransaction to the most 😅 .

I was wrong. Actually BTreeMapTransaction can be reused effortlessly.

This PR is ready for review. @yezizp2012

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang28 zwang28 added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit 211d7bc Oct 10, 2023
14 of 15 checks passed
@zwang28 zwang28 deleted the wangzheng/sql_meta_hummock_model branch October 10, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants