Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix disk out of space for GHA (attempt 2) #12671

Merged
merged 8 commits into from
Oct 9, 2023
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Oct 8, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #12671 (c88758e) into main (1fd589d) will increase coverage by 0.02%.
Report is 17 commits behind head on main.
The diff coverage is 62.95%.

❗ Current head c88758e differs from pull request most recent head 1634dd1. Consider uploading reports for the commit 1634dd1 to get more accurate results

@@            Coverage Diff             @@
##             main   #12671      +/-   ##
==========================================
+ Coverage   69.31%   69.33%   +0.02%     
==========================================
  Files        1470     1470              
  Lines      241352   241531     +179     
==========================================
+ Hits       167292   167468     +176     
- Misses      74060    74063       +3     
Flag Coverage Δ
rust 69.33% <62.95%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/src/util/mod.rs 0.00% <ø> (ø)
src/connector/src/sink/mod.rs 58.82% <100.00%> (ø)
src/connector/src/sink/writer.rs 0.00% <ø> (ø)
...onnector/src/source/google_pubsub/source/reader.rs 0.00% <ø> (ø)
src/frontend/src/catalog/system_catalog/mod.rs 94.51% <100.00%> (ø)
src/meta/src/hummock/manager/mod.rs 60.83% <ø> (ø)
...tream/src/executor/backfill/no_shuffle_backfill.rs 0.00% <ø> (ø)
src/udf/src/error.rs 0.00% <ø> (ø)
.../catalog/system_catalog/rw_catalog/rw_fragments.rs 50.00% <66.66%> (ø)
src/frontend/src/scheduler/distributed/stage.rs 15.54% <0.00%> (ø)
... and 16 more

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xxchan
Copy link
Member Author

xxchan commented Oct 8, 2023

Is it because of /dev/root

image

@xxchan xxchan changed the title chore: testing... ci: fix disk out of space for GHA (attempt 2) Oct 8, 2023
@xxchan
Copy link
Member Author

xxchan commented Oct 8, 2023

I don't understand, but it seems to be fixed...

@xxchan xxchan requested a review from BugenZhao October 8, 2023 16:10
@xxchan xxchan enabled auto-merge October 8, 2023 16:11
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 try our luck again

@xxchan xxchan added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 9db52aa Oct 9, 2023
5 of 6 checks passed
@xxchan xxchan deleted the xxchan/controversial-mink branch October 9, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants