fix(storage): auto_pick_type should cover Tombstone type #12670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto li0k/storage_fix_tombstone_pick
Codecov Report
@@ Coverage Diff @@
## main #12670 +/- ##
==========================================
+ Coverage 69.32% 69.34% +0.01%
==========================================
Files 1470 1470
Lines 241541 241543 +2
==========================================
+ Hits 167448 167489 +41
+ Misses 74093 74054 -39
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hzxa21
reviewed
Oct 8, 2023
hzxa21
approved these changes
Oct 8, 2023
…nto li0k/storage_fix_tombstone_pick
Li0k
added a commit
that referenced
this pull request
Oct 10, 2023
8 tasks
zwang28
added a commit
that referenced
this pull request
Oct 11, 2023
)" This reverts commit 1d04366.
zwang28
added a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Introduce the
compact_task::TaskType::Tombstonetoauto_pick_typeso that the compact tasks of type TaskType::Tombstone can be triggered byPullTaskEvent.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.