chore(storage): upgrade write limit #12658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto li0k/storage_upgrade_write_limit
Codecov Report
@@ Coverage Diff @@
## main #12658 +/- ##
==========================================
- Coverage 69.31% 69.30% -0.02%
==========================================
Files 1470 1470
Lines 241559 241592 +33
==========================================
- Hits 167443 167441 -2
- Misses 74116 74151 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hzxa21
approved these changes
Oct 8, 2023
src/meta/src/hummock/manager/mod.rs
Outdated
Comment on lines
526
to
559
| // We've already lowered the default limit for write limit in PR-12183, and to prevent older clusters from continuing to use the outdated configuration, we've introduced a new logic to rewrite it in a uniform way. | ||
| let mut rewrite_cg_ids = vec![]; | ||
| for (cg_id, compaction_group_config) in &mut configs { | ||
| // update write limit | ||
| let relaxed_default_write_stop_level_count = 1000; | ||
| if compaction_group_config | ||
| .compaction_config | ||
| .level0_sub_level_compact_level_count | ||
| == relaxed_default_write_stop_level_count | ||
| { | ||
| rewrite_cg_ids.push(*cg_id); | ||
| } | ||
| } | ||
|
|
||
| // update meta store | ||
| let result = self | ||
| .compaction_group_manager | ||
| .write() | ||
| .await | ||
| .update_compaction_config( | ||
| &rewrite_cg_ids, | ||
| &[ | ||
| mutable_config::MutableConfig::Level0StopWriteThresholdSubLevelNumber( | ||
| compaction_config::level0_stop_write_threshold_sub_level_number(), | ||
| ), | ||
| ], | ||
| self.env.meta_store(), | ||
| ) | ||
| .await?; | ||
|
|
||
| // update memory | ||
| for new_config in result { | ||
| configs.insert(new_config.group_id(), new_config); | ||
| } |
There was a problem hiding this comment.
Can we log the cg id and the updated config when the rewrite happens?
…nto li0k/storage_upgrade_write_limit
…nto li0k/storage_upgrade_write_limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
We've already lowered the default limit for write limit in #12183, and to prevent older clusters from continuing to use the outdated configuration, we've introduced a new logic to rewrite it in a uniform way.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.