fix(optimizer): handle eval error in LogicalSource::predicate_pushdown
#12640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fix #12523. During
LogicalSource::predicate_pushdown
, it should avoid pushdown rather than panic on evaluation error, no matter the error is:'2023-09-25 10:34:33.000000'::timestamptz
)'abc'::timestamptz
)TO_TIMESTAMP(2147483647 + 1)
)Note that when the condition contains timezone-dependent exprs, like in #12523, the condition would not be pushdown to source plan node, and the performance may not be ideal. We would still need #12633 to enable better performance. But that can be decoupled from a bug fix and added in a more controlled and limited scope.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.