Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): handle eval error in LogicalSource::predicate_pushdown #12640

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Oct 6, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #12523. During LogicalSource::predicate_pushdown, it should avoid pushdown rather than panic on evaluation error, no matter the error is:

  • missing timezone context ('2023-09-25 10:34:33.000000'::timestamptz)
  • malformed date/time string ('abc'::timestamptz)
  • overflow (TO_TIMESTAMP(2147483647 + 1))

Note that when the condition contains timezone-dependent exprs, like in #12523, the condition would not be pushdown to source plan node, and the performance may not be ideal. We would still need #12633 to enable better performance. But that can be decoupled from a bug fix and added in a more controlled and limited scope.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #12640 (5223a43) into main (e53c9f7) will increase coverage by 0.09%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #12640      +/-   ##
==========================================
+ Coverage   69.27%   69.36%   +0.09%     
==========================================
  Files        1470     1470              
  Lines      241305   241305              
==========================================
+ Hits       167162   167383     +221     
+ Misses      74143    73922     -221     
Flag Coverage Δ
rust 69.36% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...frontend/src/optimizer/plan_node/logical_source.rs 78.12% <100.00%> (ø)

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmatz lmatz added this pull request to the merge queue Oct 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 6, 2023
@lmatz lmatz added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit c847095 Oct 6, 2023
10 of 11 checks passed
@lmatz lmatz deleted the fix-12523-logical-source-predicate-pushdown-panic branch October 6, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timestamp without timezone panic when selecting from kafka source with _rw_kafka_timestamp
2 participants