Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): prepare connector libs path for iceberg sink test #12579

Merged

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #12579 (1c64ed7) into main (48b8501) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #12579      +/-   ##
==========================================
- Coverage   69.41%   69.40%   -0.01%     
==========================================
  Files        1469     1469              
  Lines      240691   240691              
==========================================
- Hits       167070   167063       -7     
- Misses      73621    73628       +7     
Flag Coverage Δ
rust 69.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also expose it in risedev? as well as dockerfiles?

@chenzl25
Copy link
Contributor Author

should we also expose it in risedev? as well as dockerfiles?

Both risedev and dockerfiles have been specified previously. We missed this one because our pull request ci doesn't run iceberg sink test.

@chenzl25 chenzl25 added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 1faa565 Sep 28, 2023
12 of 13 checks passed
@chenzl25 chenzl25 deleted the dylan/prepare_connector_libs_path_for_iceberg_sink_test branch September 28, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants