Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init cluster controller based on sql meta store #12572

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Sep 27, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #12690 .

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yezizp2012 yezizp2012 marked this pull request as ready for review October 9, 2023 03:23
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #12572 (62cd90f) into main (5bb5cce) will decrease coverage by 0.01%.
The diff coverage is 63.33%.

@@            Coverage Diff             @@
##             main   #12572      +/-   ##
==========================================
- Coverage   69.26%   69.25%   -0.01%     
==========================================
  Files        1479     1480       +1     
  Lines      242842   243562     +720     
==========================================
+ Hits       168193   168679     +486     
- Misses      74649    74883     +234     
Flag Coverage Δ
rust 69.25% <63.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/meta/src/manager/cluster.rs 74.60% <100.00%> (+0.11%) ⬆️
src/meta/src/manager/env.rs 61.78% <ø> (ø)
...rc/model_v2/migration/src/m20230908_072257_init.rs 99.18% <100.00%> (+<0.01%) ⬆️
src/meta/src/model_v2/worker.rs 100.00% <100.00%> (+100.00%) ⬆️
src/meta/src/controller/mod.rs 64.28% <0.00%> (-3.22%) ⬇️
src/meta/src/controller/cluster.rs 63.29% <63.29%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems there will be more changes for refactoring the parallel units. 🥵

@yezizp2012 yezizp2012 enabled auto-merge October 11, 2023 04:52
@yezizp2012 yezizp2012 added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit 9aac181 Oct 11, 2023
6 of 7 checks passed
@yezizp2012 yezizp2012 deleted the feat/cluster-ctl branch October 11, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(meta): cluster controller based on sql-backend
2 participants