fix: check kafka reachability without involving spec topic #12569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new function to check if the client can fetch metadata from Kafka. - Modified the logic for fetching start and stop offsets based on certain values. - Added functions to fetch offsets and start/stop offsets for partitions based on watermark and configuration. - Updated the `SinkWriterParam` type to `SinkWriterMetrics` in the `into_log_sinker` method signature. Signed-off-by: tabVersion <[email protected]>
cloudcarver
approved these changes
Sep 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #12569 +/- ##
==========================================
+ Coverage 69.37% 69.42% +0.05%
==========================================
Files 1440 1469 +29
Lines 238947 240663 +1716
==========================================
+ Hits 165762 167083 +1321
- Misses 73185 73580 +395
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
resolve #12365
as title,
in prev impl, kafka sink will reject the query if there is no such topic on the kafka side, but the brokers are available.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.