-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storage): fix delete range test timeout #12568
Conversation
…nto li0k/storage_fix_delete_range_test
Codecov Report
@@ Coverage Diff @@
## main #12568 +/- ##
==========================================
+ Coverage 69.31% 69.40% +0.09%
==========================================
Files 1469 1469
Lines 240981 241010 +29
==========================================
+ Hits 167024 167268 +244
+ Misses 73957 73742 -215
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why this PR can fix the timeout?
…nto li0k/storage_fix_delete_range_test
And this PR prefer the option 2 to mock the ReportTask event handler |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #12549
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.