Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix delete range test timeout #12568

Merged
merged 6 commits into from
Sep 28, 2023

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Sep 27, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #12549

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #12568 (9e9a598) into main (1faa565) will increase coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is 96.77%.

@@            Coverage Diff             @@
##             main   #12568      +/-   ##
==========================================
+ Coverage   69.31%   69.40%   +0.09%     
==========================================
  Files        1469     1469              
  Lines      240981   241010      +29     
==========================================
+ Hits       167024   167268     +244     
+ Misses      73957    73742     -215     
Flag Coverage Δ
rust 69.40% <96.77%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/storage/src/hummock/compactor/mod.rs 54.80% <ø> (+11.65%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 64.85% <96.77%> (+17.71%) ⬆️

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Li0k Li0k changed the title Li0k/storage fix delete range test fix(storage): fix delete range test timeout Sep 27, 2023
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Sep 27, 2023
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this PR can fix the timeout?

src/common/src/config.rs Outdated Show resolved Hide resolved
src/tests/compaction_test/src/delete_range_runner.rs Outdated Show resolved Hide resolved
@Li0k
Copy link
Contributor Author

Li0k commented Sep 28, 2023

Can you explain why this PR can fix the timeout?

#12549 (comment)

And this PR prefer the option 2 to mock the ReportTask event handler

@Li0k Li0k enabled auto-merge September 28, 2023 06:37
@Li0k Li0k added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit dc6865c Sep 28, 2023
6 of 7 checks passed
@Li0k Li0k deleted the li0k/storage_fix_delete_range_test branch September 28, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete range test timeout
3 participants