fix(stream): add assertion on stream key consistency in StreamChunk Updates
#12557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Chien <[email protected]>
BugenZhao
reviewed
Sep 27, 2023
| for record in chunk.records() { | ||
| // `chunk.records()` will check U-/U+ pairing | ||
| if let Record::Update { old_row, new_row } = record { | ||
| debug_assert!( |
There was a problem hiding this comment.
What about adding a unit test for this?
BugenZhao
approved these changes
Oct 10, 2023
8 tasks
|
This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review. |
|
After discussions, we decided to maintain the original semantics, that is, not assuming the stream key part unchanged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As suggested in #12539, this PR adds assertion on stream key consistency in
U-/U+rows inStreamChunk. Fix #12555.Many end-2-end tests will fail, so whether to temporarily comment out the assert or fix all inconsistency before merging this PR is to be decided.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.