chore(deps): Bump simd-json from 0.10.6 to 0.11.1 & fix error message #12550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
TennyZhuang
previously approved these changes
Sep 26, 2023
dependabot
bot
force-pushed
the
dependabot/cargo/simd-json-0.11.1
branch
3 times, most recently
from
b6ca1d6 to
acc09ee
Compare
Bumps [simd-json](https://github.com/simd-lite/simd-json) from 0.10.6 to 0.11.1. - [Commits](simd-lite/simd-json@v0.10.6...v0.11.1) --- updated-dependencies: - dependency-name: simd-json dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/cargo/simd-json-0.11.1
branch
from
acc09ee to
16c40fd
Compare
xxchan
changed the title
xxchan
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Before
"internal error: AccessError: TypeError { expected: \"i64\", got: \"i64\", value: \"\" }"
"internal error: AccessError: TypeError { expected: \"Some(Boolean)\", got: \"i64\", value: \"2\" }"
"internal error: AccessError: TypeError { expected: \"i16\", got: \"i16\", value: \"\" }"
test parser::debezium::simd_json_parser::tests::test2_mysql::test2_debezium_json_parser_overflow_f64 - should panic ... FAILED
"internal error: AccessError: TypeError { expected: \"i32\", got: \"i32\", value: \"\" }"
"internal error: AccessError: TypeError { expected: \"f32\", got: \"f32\", value: \"\" }"
After
"internal error: AccessError: TypeError { expected: \"Some(Int64)\", got: \"u64\", value: \"9223372036854775808\" }"
"internal error: AccessError: TypeError { expected: \"Some(Boolean)\", got: \"i64\", value: \"2\" }"
"internal error: AccessError: TypeError { expected: \"Some(Int16)\", got: \"i64\", value: \"32768\" }"
"internal error: AccessError: TypeError { expected: \"Some(Int32)\", got: \"i64\", value: \"2147483648\" }"
"internal error: AccessError: TypeError { expected: \"Some(Float32)\", got: \"f64\", value: \"380282347000000000000000000000000000000\" }"
xxchan
reviewed
Oct 6, 2023
Comment on lines
-513
to
-518
| // float64 will cause debezium simd_json_parser to panic, therefore included in the next | ||
| // test case below | ||
| } | ||
|
|
||
| #[tokio::test] | ||
| #[should_panic] |
Codecov Report
@@ Coverage Diff @@
## main #12550 +/- ##
==========================================
- Coverage 69.36% 69.30% -0.06%
==========================================
Files 1470 1470
Lines 241283 241252 -31
==========================================
- Hits 167370 167207 -163
- Misses 73913 74045 +132
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BugenZhao
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps simd-json from 0.10.6 to 0.11.1.
Commits
b6fd186(cargo-release) version 0.11.10040211Re-add arraybackend feature81348f7(cargo-release) version 0.11.03bafea8Fix docs build7c8a45cFix macro for non-serdeac53826Fix aprox number parsing238f1b0fix unsafe315b43bci version bump38e01d3return error instead of panicd34f2b6remove unsafe, bump rust-version to 1.70You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions