feat(sink): support different default sink decouple for different sink #12544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #12544 +/- ##
==========================================
- Coverage 69.43% 69.42% -0.01%
==========================================
Files 1481 1482 +1
Lines 242791 242849 +58
==========================================
+ Hits 168573 168608 +35
- Misses 74218 74241 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hzxa21
approved these changes
Oct 9, 2023
| "have checked connector is contained when create the `StreamSink`" | ||
| ).to_lowercase().as_str(), | ||
| SinkTypeName, | ||
| SinkTypeName::default_sink_decouple(), |
There was a problem hiding this comment.
Is the plan to change this to let different sink's implementation to specify whether sink decouple is enabled in the future?
There was a problem hiding this comment.
Yes. In the future different sinks will have different default sink decouple setting.
wenym1
added a commit
that referenced
this pull request
Oct 10, 2023
#12544) (#12746) Co-authored-by: William Wen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In this PR, we support specifying the default sink_decouple of each sink. Currently the default sink decouple of all sinks is
false. In the originalsink_decouplesession variable, its default value becomesdefault, which means that it will adopt the default sink decouple of the sink itself. The variable can be settrueorenableto enable sink decouple for all sinks created in the session orfalseanddisableto disable it regardless of the default sink decouple.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.