Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java-binding): store java binding row in iter #12533

Merged
merged 13 commits into from
Oct 10, 2023
Merged

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Sep 26, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously, in our java binding iterator, the next method returns newly allocated row pointer. This is bad design because we should the cost of allocation is considerable, and more importantly, it is very easy for users to forget to release the row pointer.

In this PR, we change to store the row inside the java binding iterator. In this way, we don't have to allocate a new row in each next call, and we don't have to carefully remember to close it.

After this PR, the SinkRow is not AutoClosable any more, and we don't have to wrap the rows returned from next with a try-with-resource to release the row.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 requested a review from a team as a code owner September 26, 2023 06:55
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #12533 (867433e) into main (dc6865c) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #12533      +/-   ##
==========================================
- Coverage   69.31%   69.31%   -0.01%     
==========================================
  Files        1469     1469              
  Lines      241031   241009      -22     
==========================================
- Hits       167073   167048      -25     
- Misses      73958    73961       +3     
Flag Coverage Δ
rust 69.31% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/jni_core/src/macros.rs 100.00% <ø> (ø)
src/jni_core/src/hummock_iterator.rs 0.00% <0.00%> (ø)
src/jni_core/src/stream_chunk_iterator.rs 0.00% <0.00%> (ø)
src/jni_core/src/lib.rs 1.14% <0.00%> (-0.01%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenym1 wenym1 added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit 95e0136 Oct 10, 2023
6 of 7 checks passed
@wenym1 wenym1 deleted the yiming/java-row-in-iter branch October 10, 2023 03:22
wenym1 added a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants