feat(meta): add create_type to Table
#12529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can just have breaking change for the proto. |
kwannoel
changed the title
Table
kwannoel
added
ci/run-backwards-compat-tests
kwannoel
force-pushed
the
kwannoel/diff
branch
from
ae7514b to
8ca7ba0
Compare
Codecov Report
@@ Coverage Diff @@
## main #12529 +/- ##
=======================================
Coverage 69.40% 69.41%
=======================================
Files 1429 1429
Lines 238724 238722 -2
=======================================
+ Hits 165697 165700 +3
+ Misses 73027 73022 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
45 tasks
chenzl25
approved these changes
Sep 26, 2023
BugenZhao
approved these changes
Sep 26, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
BugenZhao
pushed a commit
that referenced
this pull request
Sep 27, 2023
…2123) feat(java-binding): generate jni method signature with macro (#12487) feat(streaming): recover `no_shuffle_backfill` (#12493) feat(test): support customized source logic in deterministic test (#12456) refactor(storage): reorg selector (#12392) feat(frontend): add rw_catalog.rw_hummock_sstables (#12532) chore: bump risingwave version in docker compose to 1.2.0 (#12530) Signed-off-by: Bugen Zhao <[email protected]> refactor(sink): decouple sink formatter and payload writer (#12515) chore(java-binding): refine stream chunk benchmark (#12504) feat(meta): add create_type to `Table` (#12529) refactor(sink): refine sink trait and macro (#12478) refactor(backup): refine error message (#12388) feat(sink): turn sink writer into higher level log sinker (#12152) fix(over window): don't expect stream keys in UpdateDelete and UpdateInsert the same (#12536) Signed-off-by: Richard Chien <[email protected]> refactor(expr): separate function implementations into a new crate (#12485) Signed-off-by: Runji Wang <[email protected]> fix(config): make metrics_level opt backward compatible (#12541) refactor(connector): replace sink writer rpc with jni (#12480) refactor(connector): remove `WriteGuard` and `fulfill_meta_column` from parser (#12542) Signed-off-by: Bugen Zhao <[email protected]> feat(sink): handle stream key sink pk mismatch (#12458) feat(optimizer): support apply hop window transpose rule (#12338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add
create_type, so we can distinguish between background and foreground mvs, when deciding which to persist.Foreground mvs' backfill progress will not be recovered.
Note that we have breaking change for the proto
CreateMaterializedViewRequest. Itsstream_job_execution_modefield is deleted in this PR.This is only introduced recently #12355, and it is not persisted, so we can just remove it.
This field is now maintained in
Table's proto definition.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.