Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase timeout for unit test/buid-other #12498

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 23, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Timeouts frequently

image

For unit test, although some timeouts are due to flaky test (#11979), we can see it's still very close to timeout.

image

build-other

image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #12498 (ebebe0c) into main (5ab1f7a) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #12498      +/-   ##
==========================================
- Coverage   69.45%   69.43%   -0.03%     
==========================================
  Files        1429     1429              
  Lines      238594   238594              
==========================================
- Hits       165707   165659      -48     
- Misses      72887    72935      +48     
Flag Coverage Δ
rust 69.43% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xxchan xxchan added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit a0f0b6a Sep 25, 2023
@xxchan xxchan deleted the xxchan/empirical-gayal branch September 25, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants