fix: ignore when fail to remove label in batch monitor #12490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Li0k
approved these changes
Sep 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #12490 +/- ##
==========================================
- Coverage 69.53% 69.53% -0.01%
==========================================
Files 1429 1429
Lines 238177 238175 -2
==========================================
- Hits 165624 165622 -2
Misses 72553 72553
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hzxa21
pushed a commit
that referenced
this pull request
Sep 22, 2023
Co-authored-by: ZENOTME <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Sep 22, 2023
Co-authored-by: ZENOTME <[email protected]>
chenzl25
pushed a commit
that referenced
this pull request
Sep 22, 2023
Co-authored-by: ZENOTME <[email protected]> Co-authored-by: ZENOTME <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
related: #12489
Just ignore it to avoid panic, fix it later.
Checklist
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future)../risedev check(or alias,./risedev c)[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.