fix(citus-cdc): fix publication alter of citus connector #12488
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 4177 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1830 | 1 | 2346 | 0 |
Click to see the invalid file list
- java/connector-node/risingwave-connector-service/src/main/java/com/risingwave/connector/source/common/CitusValidator.java
...e-connector-service/src/main/java/com/risingwave/connector/source/common/CitusValidator.java
Show resolved
Hide resolved
StrikeW
force-pushed
the
siyuan/citus-cdc
branch
from
ed0cf7c to
ba2db74
Compare
| @@ -20,5 +20,30 @@ CREATE TABLE orders_rw ( | |||
| schema.name = 'public', | |||
| table.name = 'orders', | |||
| slot.name = 'orders_dbz_slot', | |||
| publication.create.enable = 'true' | |||
There was a problem hiding this comment.
so publication.create.enable = 'true' is a default behavior?
There was a problem hiding this comment.
Yes, user can create and provide their own pub.
|
and can you explain why we need this change? I am not familiar with citus context |
Our citus connector will create a |
Codecov Report
@@ Coverage Diff @@
## main #12488 +/- ##
=======================================
Coverage 69.41% 69.41%
=======================================
Files 1469 1469
Lines 240691 240691
=======================================
+ Hits 167070 167072 +2
+ Misses 73621 73619 -2
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
citus connector will create a FOR ALL TABLES publication, which will replicates changes for all tables in the database, including tables created in the future. And it cannot be altered afterwards.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.