-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): add nats integration test #12471
Conversation
You may need to add |
Hi @yufansong, do you plan to go on this work? |
Oh, almost forget this one. I can continue this one in next week. Currently busy with some more urgent task. Thanks for remind. @StrikeW |
Continue to work on this PR this week. |
@StrikeW I have checked the But I didn't directly run the |
You can build a docker image against your branch then trigger the integration test pipeline manually from buildkite and specify your image via the |
Yeah, I test it in buildkite intergration-test workflow and the result is correct. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12471 +/- ##
=======================================
Coverage 68.06% 68.07%
=======================================
Files 1548 1548
Lines 267474 267474
=======================================
+ Hits 182052 182075 +23
+ Misses 85422 85399 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically LGTM, are there related tests in CI?
@tabVersion I manually trigger the test here |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
Add integration test for nats source/sink.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.