feat(sink): handle stream key sink pk mismatch #12458
Merged
+278
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st1page
commented
Sep 20, 2023
|
blocked on #12460 |
Codecov Report
@@ Coverage Diff @@
## main #12458 +/- ##
==========================================
+ Coverage 69.40% 69.42% +0.01%
==========================================
Files 1440 1440
Lines 238757 238903 +146
==========================================
+ Hits 165713 165859 +146
Misses 73044 73044
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Could you add some context for the problem that would be helpful for future reference? |
fuyufjh
approved these changes
Sep 26, 2023
hzxa21
approved these changes
Sep 26, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
st1page
force-pushed
the
sts/stream_key_sink_pk_mismatch
branch
from
e87f52d to
b86af93
Compare
st1page
commented
Sep 27, 2023
| @@ -177,6 +177,7 @@ async fn test_sink_basic() -> Result<()> { | |||
| sleep(Duration::from_millis(10)).await; | |||
| } | |||
| } | |||
| sleep(Duration::from_millis(10000)).await; | |||
BugenZhao
pushed a commit
that referenced
this pull request
Sep 27, 2023
…2123) feat(java-binding): generate jni method signature with macro (#12487) feat(streaming): recover `no_shuffle_backfill` (#12493) feat(test): support customized source logic in deterministic test (#12456) refactor(storage): reorg selector (#12392) feat(frontend): add rw_catalog.rw_hummock_sstables (#12532) chore: bump risingwave version in docker compose to 1.2.0 (#12530) Signed-off-by: Bugen Zhao <[email protected]> refactor(sink): decouple sink formatter and payload writer (#12515) chore(java-binding): refine stream chunk benchmark (#12504) feat(meta): add create_type to `Table` (#12529) refactor(sink): refine sink trait and macro (#12478) refactor(backup): refine error message (#12388) feat(sink): turn sink writer into higher level log sinker (#12152) fix(over window): don't expect stream keys in UpdateDelete and UpdateInsert the same (#12536) Signed-off-by: Richard Chien <[email protected]> refactor(expr): separate function implementations into a new crate (#12485) Signed-off-by: Runji Wang <[email protected]> fix(config): make metrics_level opt backward compatible (#12541) refactor(connector): replace sink writer rpc with jni (#12480) refactor(connector): remove `WriteGuard` and `fulfill_meta_column` from parser (#12542) Signed-off-by: Bugen Zhao <[email protected]> feat(sink): handle stream key sink pk mismatch (#12458) feat(optimizer): support apply hop window transpose rule (#12338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #12026
fix #12447
the algorithm is #12026 (comment)
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.