Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): support customized source logic in deterministic test #12456

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Sep 20, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Support test source, which in deterministic test allows dynamically registering customized list_splits and into_data_stream logic.

The deterministic sink test are modified to use test source accordingly.

Future PR will leverage this feature to enable more test for sink decouple.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 requested a review from a team as a code owner September 20, 2023 07:35
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #12456 (66647c1) into main (14292d7) will decrease coverage by 0.03%.
Report is 5 commits behind head on main.
The diff coverage is 4.42%.

@@            Coverage Diff             @@
##             main   #12456      +/-   ##
==========================================
- Coverage   69.66%   69.63%   -0.03%     
==========================================
  Files        1424     1425       +1     
  Lines      236374   236485     +111     
==========================================
+ Hits       164675   164683       +8     
- Misses      71699    71802     +103     
Flag Coverage Δ
rust 69.63% <4.42%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/connector/src/source/test_source.rs 0.00% <0.00%> (ø)
src/connector/src/macros.rs 50.00% <100.00%> (ø)
src/frontend/src/handler/create_source.rs 48.62% <100.00%> (+0.15%) ⬆️
src/stream/src/executor/wrapper/schema_check.rs 97.82% <100.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Cargo.lock

@wenym1 wenym1 added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 417561d Sep 26, 2023
@wenym1 wenym1 deleted the yiming/deterministic-test-source branch September 26, 2023 06:49
BugenZhao pushed a commit that referenced this pull request Sep 27, 2023
…2123)

feat(java-binding): generate jni method signature with macro (#12487)

feat(streaming): recover `no_shuffle_backfill` (#12493)

feat(test): support customized source logic in deterministic test (#12456)

refactor(storage): reorg selector (#12392)

feat(frontend): add rw_catalog.rw_hummock_sstables (#12532)

chore: bump risingwave version in docker compose to 1.2.0 (#12530)

Signed-off-by: Bugen Zhao <[email protected]>

refactor(sink): decouple sink formatter and payload writer (#12515)

chore(java-binding): refine stream chunk benchmark (#12504)

feat(meta): add create_type to `Table` (#12529)

refactor(sink): refine sink trait and macro (#12478)

refactor(backup): refine error message (#12388)

feat(sink): turn sink writer into higher level log sinker (#12152)

fix(over window): don't expect stream keys in UpdateDelete and UpdateInsert the same (#12536)

Signed-off-by: Richard Chien <[email protected]>

refactor(expr): separate function implementations into a new crate (#12485)

Signed-off-by: Runji Wang <[email protected]>

fix(config): make metrics_level opt backward compatible (#12541)

refactor(connector): replace sink writer rpc with jni (#12480)

refactor(connector): remove `WriteGuard` and `fulfill_meta_column` from parser (#12542)

Signed-off-by: Bugen Zhao <[email protected]>

feat(sink): handle stream key sink pk mismatch (#12458)

feat(optimizer): support apply hop window transpose rule (#12338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants