-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expr): add _pg_expandarray
function
#12448
Conversation
Signed-off-by: Runji Wang <[email protected]>
Is there a way to ignore the lint?
|
Signed-off-by: TennyZhuang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It seems that buf lint
does not support fine-grained ignoring. The only way is to name it as PG_EXPANDARRAY and rewrite it in the frontend.
I found this. |
Signed-off-by: Runji Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #12448 +/- ##
==========================================
- Coverage 69.64% 69.63% -0.01%
==========================================
Files 1422 1423 +1
Lines 235747 235782 +35
==========================================
+ Hits 164192 164198 +6
- Misses 71555 71584 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Will https://buf.build/docs/lint/overview#allow_comment_ignores be better? |
Signed-off-by: Runji Wang <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Added a new table function
_pg_expandarray
.fix #12204
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Add a new table function:
Returns the input array as a set of rows with an index.