Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): iceberg sink test failure #12446

Merged
merged 5 commits into from
Sep 20, 2023
Merged

fix(ci): iceberg sink test failure #12446

merged 5 commits into from
Sep 20, 2023

Conversation

liurenjie1024
Copy link
Contributor

@liurenjie1024 liurenjie1024 commented Sep 20, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

See https://buildkite.com/risingwavelabs/main-cron/builds/861#018aaf19-2ac2-4d4f-9331-40f910d0c36d

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@liurenjie1024 liurenjie1024 requested a review from a team as a code owner September 20, 2023 07:42
@liurenjie1024
Copy link
Contributor Author

cc @BugenZhao for Cargo.lock

@kwannoel kwannoel changed the title fix: Fix test main cron failure fix: iceberg sink test failure Sep 20, 2023
@kwannoel kwannoel changed the title fix: iceberg sink test failure fix(main-cron): iceberg sink test failure Sep 20, 2023
@kwannoel kwannoel changed the title fix(main-cron): iceberg sink test failure fix(ci): iceberg sink test failure Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #12446 (af0ecef) into main (8431a44) will decrease coverage by 0.01%.
Report is 9 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #12446      +/-   ##
==========================================
- Coverage   69.64%   69.64%   -0.01%     
==========================================
  Files        1422     1422              
  Lines      235747   235767      +20     
==========================================
+ Hits       164182   164189       +7     
- Misses      71565    71578      +13     
Flag Coverage Δ
rust 69.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/connector/src/sink/iceberg.rs 16.56% <0.00%> (-1.13%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liurenjie1024 liurenjie1024 added this pull request to the merge queue Sep 20, 2023
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for Cargo.lock

Merged via the queue into main with commit c9f3cd0 Sep 20, 2023
@liurenjie1024 liurenjie1024 deleted the renjie/fix-main-test branch September 20, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants