Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): calculate lru_evicted_watermark_time_diff_ms in promsql #12431

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

yuhao-su
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • calculate the diff between current watermark and evicted watermark in promsql instead of RW.

Close #12293

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yuhao-su yuhao-su changed the title fix(dashboard) fix(dashboard): calculate lru_evicted_watermark_time_diff_ms in promsql Sep 19, 2023
@yuhao-su yuhao-su requested a review from wcy-fdu September 19, 2023 12:55
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #12431 (0898101) into main (a7b7688) will increase coverage by 0.00%.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##             main   #12431   +/-   ##
=======================================
  Coverage   69.71%   69.71%           
=======================================
  Files        1427     1427           
  Lines      237432   237430    -2     
=======================================
+ Hits       165518   165523    +5     
+ Misses      71914    71907    -7     
Flag Coverage Δ
rust 69.71% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/stream/src/cache/managed_lru.rs 89.36% <85.71%> (-0.09%) ⬇️
src/stream/src/executor/monitor/streaming_stats.rs 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yuhao-su yuhao-su requested a review from st1page September 20, 2023 10:29
Copy link
Contributor

@wcy-fdu wcy-fdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some screenshots to show your change?

@BugenZhao BugenZhao requested a review from hzxa21 September 20, 2023 10:59
@yuhao-su
Copy link
Contributor Author

image

@yuhao-su yuhao-su requested a review from wcy-fdu September 21, 2023 06:59
@yuhao-su yuhao-su enabled auto-merge September 21, 2023 07:06
@yuhao-su yuhao-su added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit f075a6b Sep 21, 2023
6 of 7 checks passed
@yuhao-su yuhao-su deleted the yuhao/fix_lru_watermark_diff branch September 21, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(metrics): Invalid data reported: lru_evicted_watermark_time_diff_ms
2 participants