Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix duplicated jeprof (again) #12424

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 19, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Cannot understand why

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan requested a review from a team as a code owner September 19, 2023 09:24
@xxchan xxchan enabled auto-merge September 19, 2023 09:25
@xxchan xxchan added this pull request to the merge queue Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #12424 (a724da6) into main (7df7eb2) will decrease coverage by 0.16%.
Report is 11 commits behind head on main.
The diff coverage is 64.45%.

@@            Coverage Diff             @@
##             main   #12424      +/-   ##
==========================================
- Coverage   69.80%   69.65%   -0.16%     
==========================================
  Files        1425     1422       -3     
  Lines      237335   235886    -1449     
==========================================
- Hits       165668   164296    -1372     
+ Misses      71667    71590      -77     
Flag Coverage Δ
rust 69.65% <64.45%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/batch/src/executor/hop_window.rs 75.24% <ø> (ø)
src/batch/src/executor/join/nested_loop_join.rs 98.95% <ø> (ø)
src/batch/src/executor/limit.rs 87.11% <ø> (-0.45%) ⬇️
src/batch/src/executor/source.rs 0.00% <0.00%> (ø)
src/batch/src/executor/update.rs 81.15% <ø> (ø)
.../batch/src/task/consistent_hash_shuffle_channel.rs 0.00% <0.00%> (ø)
src/batch/src/task/hash_shuffle_channel.rs 0.00% <0.00%> (ø)
src/common/src/array/compact_chunk.rs 97.01% <ø> (ø)
src/common/src/array/mod.rs 88.10% <ø> (ø)
src/common/src/array/struct_array.rs 85.07% <0.00%> (ø)
... and 97 more

... and 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit ed96064 Sep 19, 2023
10 of 12 checks passed
@xxchan xxchan deleted the xxchan/independent-marsupial branch September 19, 2023 10:13
fuyufjh added a commit that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants