Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(state_table): state table try flush for non-checkpoint barrier #12418

Closed
wants to merge 43 commits into from

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Sep 19, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#12419

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wcy-fdu wcy-fdu marked this pull request as draft September 19, 2023 08:26
@wcy-fdu wcy-fdu marked this pull request as ready for review September 19, 2023 09:58
src/storage/src/hummock/store/local_hummock_storage.rs Outdated Show resolved Hide resolved
src/storage/src/mem_table.rs Outdated Show resolved Hide resolved
src/storage/src/mem_table.rs Outdated Show resolved Hide resolved
src/storage/src/hummock/store/local_hummock_storage.rs Outdated Show resolved Hide resolved
@wcy-fdu wcy-fdu changed the title feat(state_table): add try flush interface and apply barrier level spill for hash join feat(state_table): state table try flush for non-checkpoint barrier Sep 20, 2023
@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Oct 11, 2023

New update:
We decided to keep non-checkpoint barrier and try_flush interface, but barrier and checkpoint decouple are not turned on by default. @hzxa21 PTAL

@wcy-fdu wcy-fdu requested a review from hzxa21 October 11, 2023 10:45
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 382 lines in your changes are missing coverage. Please review.

Comparison is base (132f7a1) 68.17% compared to head (32d56db) 68.20%.
Report is 17 commits behind head on main.

Files Patch % Lines
src/compute/src/memory/controller.rs 0.00% 87 Missing ⚠️
src/object_store/src/object/s3.rs 0.00% 50 Missing ⚠️
src/compute/src/memory/manager.rs 0.00% 48 Missing ⚠️
...log/rw_catalog/rw_hummock_compact_task_progress.rs 0.00% 35 Missing ⚠️
src/object_store/src/object/mod.rs 46.87% 17 Missing ⚠️
src/meta/service/src/hummock_service.rs 0.00% 14 Missing ⚠️
src/stream/src/common/table/state_table.rs 81.96% 11 Missing ⚠️
src/meta/model_v2/src/hummock_version_delta.rs 0.00% 9 Missing ⚠️
src/rpc_client/src/meta_client.rs 0.00% 9 Missing ⚠️
...catalog/rw_catalog/rw_hummock_compaction_status.rs 0.00% 8 Missing ⚠️
... and 26 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12418      +/-   ##
==========================================
+ Coverage   68.17%   68.20%   +0.02%     
==========================================
  Files        1521     1523       +2     
  Lines      261770   262027     +257     
==========================================
+ Hits       178459   178705     +246     
- Misses      83311    83322      +11     
Flag Coverage Δ
rust 68.20% <54.84%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Nov 28, 2023

PTAL @hzxa21 ❤️

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Jan 30, 2024

Will open this PR if needed.

@wcy-fdu wcy-fdu closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants