Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(udf): use cfg_or_panic for UDF implementations #12416

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Sep 19, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. 💦 Check https://crates.io/crates/cfg-or-panic for more details.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Bugen Zhao <[email protected]>
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao enabled auto-merge September 19, 2023 08:35
@BugenZhao BugenZhao added this pull request to the merge queue Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #12416 (7d3876d) into main (a789c61) will increase coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #12416      +/-   ##
==========================================
+ Coverage   69.74%   69.76%   +0.02%     
==========================================
  Files        1424     1424              
  Lines      236429   236339      -90     
==========================================
- Hits       164889   164883       -6     
+ Misses      71540    71456      -84     
Flag Coverage Δ
rust 69.76% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/expr/src/expr/expr_udf.rs 0.00% <0.00%> (ø)
src/expr/src/table_function/user_defined.rs 0.00% <0.00%> (ø)
src/udf/src/external.rs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 7177a3e Sep 19, 2023
7 of 8 checks passed
@BugenZhao BugenZhao deleted the bz/expr-cfg-or-panic branch September 19, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants