Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): tune datagen range #12408

Merged
merged 1 commit into from
Sep 19, 2023
Merged

chore(test): tune datagen range #12408

merged 1 commit into from
Sep 19, 2023

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Sep 19, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR allows to specify start and end of datagen connector to the same value as below:

fields.v.start = 123,
fields.v.end  = 123,

Thus we can get v in range [123, 123].

This PR also remove all set CREATE_COMPACTION_GROUP_FOR_MV to true; from tests, because CREATE_COMPACTION_GROUP_FOR_MV is default to false in production, and none of these tests are designed to test CREATE_COMPACTION_GROUP_FOR_MV in the first place.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28 zwang28 force-pushed the wangzheng/chore_test branch from 84f6ec3 to 41ccebc Compare September 19, 2023 04:16
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang28 zwang28 added this pull request to the merge queue Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #12408 (41ccebc) into main (b17569d) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main   #12408      +/-   ##
==========================================
- Coverage   69.75%   69.75%   -0.01%     
==========================================
  Files        1424     1424              
  Lines      236313   236310       -3     
==========================================
- Hits       164838   164829       -9     
- Misses      71475    71481       +6     
Flag Coverage Δ
rust 69.75% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/risedevtool/src/bin/risedev-docslt.rs 0.00% <0.00%> (ø)
src/common/src/field_generator/numeric.rs 96.81% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 0ae5c0e Sep 19, 2023
@zwang28 zwang28 deleted the wangzheng/chore_test branch September 19, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants