fix(sink): fix integer array type for remote sink #12334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikeW
approved these changes
Sep 15, 2023
wenym1
approved these changes
Sep 15, 2023
StrikeW
reviewed
Sep 15, 2023
| RW_TYPE_TO_JDBC_TYPE_NAME.put(TypeName.TIMESTAMP, "timestamp"); | ||
| RW_TYPE_TO_JDBC_TYPE_NAME.put(TypeName.INTERVAL, "varchar"); | ||
| RW_TYPE_TO_JDBC_TYPE_NAME.put(TypeName.DATE, "date"); | ||
| RW_TYPE_TO_JDBC_TYPE_NAME.put(TypeName.TIMESTAMPTZ, "timestampz"); |
There was a problem hiding this comment.
timestampz should be timestamptz, tz in the end
There was a problem hiding this comment.
Good catch. Fixed in the latest commit.
hzxa21
force-pushed
the
patrick/fix-remote-sink-array
branch
from
3130eb7 to
204d9db
Compare
Codecov Report
@@ Coverage Diff @@
## main #12334 +/- ##
==========================================
+ Coverage 68.62% 68.68% +0.05%
==========================================
Files 1496 1496
Lines 249578 249578
==========================================
+ Hits 171270 171415 +145
+ Misses 78308 78163 -145
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
CI passed, shall we merge this PR? @hzxa21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
There is a typo in the
valueOffunction signature for Integer/Short/Long causing errors when the remote sink is trying to get value from array.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.