-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): build jemallocator only on linux #12316
Conversation
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Interesting. Why there're two versions? And how's docker build related to the behavior under macOS? |
🤣 Still investigating. |
|
I guess the key difference is that we made it a required dependency instead of an optional one. There must be some problems while handling this, in hakari for example... |
Codecov Report
@@ Coverage Diff @@
## main #12316 +/- ##
=======================================
Coverage 69.95% 69.95%
=======================================
Files 1411 1411
Lines 235325 235325
=======================================
+ Hits 164612 164623 +11
+ Misses 70713 70702 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Duplicated #12320 . |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
A temporary fix to pass docker pipeline. Issue: #12315
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.