Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): build jemallocator only on linux #12316

Closed
wants to merge 2 commits into from
Closed

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Sep 14, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

A temporary fix to pass docker pipeline. Issue: #12315

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Sep 14, 2023
@MrCroxx MrCroxx marked this pull request as ready for review September 14, 2023 12:11
@MrCroxx MrCroxx requested a review from a team as a code owner September 14, 2023 12:11
@MrCroxx
Copy link
Contributor Author

MrCroxx commented Sep 14, 2023

Signed-off-by: MrCroxx <[email protected]>
@BugenZhao
Copy link
Member

BugenZhao commented Sep 14, 2023

Interesting. Why there're two versions? And how's docker build related to the behavior under macOS?

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Sep 14, 2023

Interesting. Why there're two versions? And how's docker build related to the behavior under macOS?

🤣 Still investigating.

@yuhao-su
Copy link
Contributor

  1. Why there're two versions as @BugenZhao mentioned.
  2. Why there're so many package in workspace-hack [build-dependencies]...

@BugenZhao
Copy link
Member

I guess the key difference is that we made it a required dependency instead of an optional one. There must be some problems while handling this, in hakari for example...

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #12316 (540e373) into main (0e72056) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #12316   +/-   ##
=======================================
  Coverage   69.95%   69.95%           
=======================================
  Files        1411     1411           
  Lines      235325   235325           
=======================================
+ Hits       164612   164623   +11     
+ Misses      70713    70702   -11     
Flag Coverage Δ
rust 69.95% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/compute/src/rpc/service/monitor_service.rs 0.00% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Sep 14, 2023

Duplicated #12320 .

@MrCroxx MrCroxx closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants