refactor(expr): allow defining functions in frontend #12287

TennyZhuang · 2023-09-13T15:20:27Z

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Related #11752

Checklist

I have written necessary rustdoc comments
I have added necessary unit tests and integration tests
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
All checks passed in ./risedev check (or alias, ./risedev c)
My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: TennyZhuang <[email protected]>

github-actions

license-eye has totally checked 4126 files.

Valid	Invalid	Ignored	Fixed
1797	2	2327	0

Click to see the invalid file list

src/frontend/src/expr/function/col_description.rs
src/frontend/src/expr/function/mod.rs

src/frontend/src/expr/function/col_description.rs

src/frontend/src/expr/function/mod.rs

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

wangrunji0408

LGTM!

wangrunji0408 · 2023-09-13T16:50:49Z

src/frontend/Cargo.toml

@@ -54,6 +55,7 @@ risingwave_common = { workspace = true }
 risingwave_common_service = { workspace = true }
 risingwave_connector = { workspace = true }
 risingwave_expr = { workspace = true }
+risingwave_expr_macro = { workspace = true }


We can re-export these macros from the expr crate so that we don't need to depend on the macro crate. (like #[tokio::main])

No idea how to do that, we've already made risingwave_expr::function mod public.

We can remove that empty module now to avoid name conflict. 🤣

wangrunji0408 · 2023-09-13T16:52:07Z

src/frontend/Cargo.toml

@@ -24,6 +24,7 @@ auto_enums = { version = "0.8", features = ["futures03"] }
 bk-tree = "0.5.0"
 bytes = "1"
 clap = { version = "4", features = ["derive"] }
+ctor = "0.2"


How about re-exporting ctor::ctor from the expr crate?

wangrunji0408 · 2023-09-13T16:53:24Z

src/expr/src/lib.rs

@@ -24,6 +24,8 @@
 #![feature(test)]
 #![feature(arc_unwrap_or_clone)]

+extern crate self as risingwave_expr;


Today I learned. 🤯

BugenZhao

LGTM

src/frontend/src/expr/function/col_description.rs

xiangjinwu

lgtm

src/frontend/src/expr/mod.rs

…-in-frontend

Signed-off-by: TennyZhuang <[email protected]>

codecov · 2023-09-18T07:58:34Z

Codecov Report

Merging #12287 (0b8fbb8) into main (784fe56) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main   #12287      +/-   ##
==========================================
- Coverage   69.87%   69.86%   -0.01%     
==========================================
  Files        1419     1420       +1     
  Lines      235801   235808       +7     
==========================================
- Hits       164765   164757       -8     
- Misses      71036    71051      +15

Flag	Coverage Δ
rust	`69.86% <81.81%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
src/batch/src/executor/sort_over_window.rs	`0.00% <ø> (ø)`
src/expr/src/window_function/state/aggregate.rs	`97.11% <ø> (ø)`
src/expr/src/window_function/state/buffer.rs	`98.70% <ø> (ø)`
src/expr/src/window_function/state/mod.rs	`50.00% <ø> (ø)`
src/expr/src/window_function/state/row_number.rs	`96.29% <ø> (ø)`
src/frontend/src/expr/mod.rs	`77.77% <ø> (ø)`
src/frontend/src/expr/window_function.rs	`55.78% <ø> (ø)`
...end/src/optimizer/plan_node/generic/over_window.rs	`92.10% <ø> (ø)`
...end/src/optimizer/plan_node/logical_over_window.rs	`91.41% <ø> (ø)`
...optimizer/rule/over_window_to_agg_and_join_rule.rs	`98.57% <ø> (ø)`
... and 7 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

commit c82fc9c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Sep 18 08:37:33 2023 +0000 chore(deps): Bump chrono from 0.4.30 to 0.4.31 (#12359) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Runji Wang <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Runji Wang <[email protected]> Co-authored-by: TennyZhuang <[email protected]> commit cbdc1ac Author: Huangjw <[email protected]> Date: Mon Sep 18 16:22:35 2023 +0800 chore(ci): move release jobs to main-cron pipeline (#12339) commit b37a19c Author: Yuhao Su <[email protected]> Date: Mon Sep 18 16:18:01 2023 +0800 feat(dashboard): add memory profiling (#12052) commit 71d8170 Author: TennyZhuang <[email protected]> Date: Mon Sep 18 15:58:26 2023 +0800 refactor(expr): allow defining functions in frontend (#12287) Signed-off-by: TennyZhuang <[email protected]> Co-authored-by: zwang28 <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit cedaec9 Author: Dylan <[email protected]> Date: Mon Sep 18 15:54:10 2023 +0800 feat(optimizer): support agg group by simplify rule (#12349) commit 71d9b0b Author: Noel Kwan <[email protected]> Date: Mon Sep 18 15:32:00 2023 +0800 feat(meta): update StreamJob status on finish (#12342) commit 784fe56 Author: zwang28 <[email protected]> Date: Mon Sep 18 14:47:49 2023 +0800 fix(backup): ensure correct delta log order (#12371) commit 711ecd5 Author: congyi wang <[email protected]> Date: Mon Sep 18 14:11:24 2023 +0800 feat(state_table): add iterator sub range under a certain pk prefix (#12251) commit 1877aed Author: xiangjinwu <[email protected]> Date: Mon Sep 18 13:49:15 2023 +0800 refactor(sink): impl SinkFormatter for AppendOnly and Upsert (#12321) commit f304ed2 Author: xxchan <[email protected]> Date: Sun Sep 17 20:20:17 2023 +0800 revert: Revert "chore: add platforms to hakari (#12333)" (#12363) commit a975d93 Author: Bohan Zhang <[email protected]> Date: Sun Sep 17 19:04:24 2023 +0800 fix: handle kafka sink message timeout error (#12350) commit 8ef74ad Author: Runji Wang <[email protected]> Date: Sat Sep 16 12:16:02 2023 +0800 fix(udf): handle visibility of input chunks in UDTF (#12357) Signed-off-by: Runji Wang <[email protected]> commit 31fdc26 Author: Xu <[email protected]> Date: Fri Sep 15 21:01:14 2023 -0400 feat(expr): switch to `fancy-regex` crate & update the original version (#12329) Co-authored-by: xzhseh <[email protected]> commit 0032145 Author: Runji Wang <[email protected]> Date: Fri Sep 15 16:57:25 2023 +0800 refactor(expr): support variadic function in `#[function]` macro (#12178) Signed-off-by: Runji Wang <[email protected]> commit 467ba4b Author: stonepage <[email protected]> Date: Fri Sep 15 16:28:13 2023 +0800 fix: stream backfill executor use correct schema (#12314) Co-authored-by: Noel Kwan <[email protected]> commit c443197 Author: Dylan <[email protected]> Date: Fri Sep 15 16:22:13 2023 +0800 feat(optimizer): support correlated column in order by (#12341) commit 8a36ca3 Author: Noel Kwan <[email protected]> Date: Fri Sep 15 16:11:03 2023 +0800 feat(meta): Add `creating_status` field for stream jobs (#12330) commit bf5b14e Author: zwang28 <[email protected]> Date: Fri Sep 15 16:06:17 2023 +0800 chore: lift decoding message size limit for ddl client (#12340) commit c0060b2 Author: zwang28 <[email protected]> Date: Fri Sep 15 15:32:14 2023 +0800 feat(meta): add hummock config relevant tables to rw_catalog (#12337) commit 59bb645 Author: xxchan <[email protected]> Date: Fri Sep 15 14:54:54 2023 +0800 chore: add platforms to hakari (#12333) Signed-off-by: Runji Wang <[email protected]> Co-authored-by: Runji Wang <[email protected]> commit 7baa27f Author: Bugen Zhao <[email protected]> Date: Fri Sep 15 14:00:14 2023 +0800 chore: split full debug info for release build (#12255) Signed-off-by: Bugen Zhao <[email protected]> commit a99e6f3 Author: Richard Chien <[email protected]> Date: Fri Sep 15 13:58:19 2023 +0800 fix(stream): fix pk indices of GroupTopN executors (#12304) Signed-off-by: Richard Chien <[email protected]> commit 43c010e Author: Croxx <[email protected]> Date: Fri Sep 15 11:59:41 2023 +0800 chore: fix comment and metrics (#12331) Signed-off-by: MrCroxx <[email protected]> commit 214118b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Sep 15 10:03:14 2023 +0800 chore(deps): Bump serde_json from 1.0.106 to 1.0.107 (#12322) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 41ebb2a Author: Xu <[email protected]> Date: Thu Sep 14 22:02:08 2023 -0400 fix(regexp): substraction overflow when incorrectly speicifying `start` (#12325) commit a566cfe Author: Xu <[email protected]> Date: Thu Sep 14 12:58:35 2023 -0400 feat(expr): add `array_sum` (#12162) Signed-off-by: Runji Wang <[email protected]> Co-authored-by: Runji Wang <[email protected]> commit 28bbf10 Author: Croxx <[email protected]> Date: Fri Sep 15 00:40:27 2023 +0800 fix(ci): exclude tikv-jemalloc-sys in hakari check (#12320) Signed-off-by: MrCroxx <[email protected]> commit 5aa5a47 Author: zwang28 <[email protected]> Date: Thu Sep 14 21:02:01 2023 +0800 feat(meta): add hummock version relevant tables to rw_catalog (#12309) commit a740364 Author: Huangjw <[email protected]> Date: Thu Sep 14 19:11:04 2023 +0800 chore(ci): install locales in prebuilt image (#12311) Signed-off-by: Bugen Zhao <[email protected]> Co-authored-by: Bugen Zhao <[email protected]> commit 0e72056 Author: StrikeW <[email protected]> Date: Thu Sep 14 18:42:34 2023 +0800 refactor(jdbc-sink): execute statements in batch and set isolation level to RC (#12250) commit 827ed5e Author: Dylan <[email protected]> Date: Thu Sep 14 17:31:41 2023 +0800 refactor(connector): migrate cdc source metric from connector to compute (#12283) commit a934185 Author: Dylan <[email protected]> Date: Thu Sep 14 17:31:04 2023 +0800 fix(optimizer): relax scan predicate pull up mapping inverse restriction (#12308) commit db0c099 Author: Dylan <[email protected]> Date: Thu Sep 14 17:30:28 2023 +0800 feat(stream): handling watermark in temporal join (#12302) commit 1ecea63 Author: Bugen Zhao <[email protected]> Date: Thu Sep 14 16:43:14 2023 +0800 refactor(risedev): split the steps for building and running playground (#12279) Signed-off-by: Bugen Zhao <[email protected]> Co-authored-by: xxchan <[email protected]> commit ae4b1f8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Sep 14 08:41:29 2023 +0000 chore(deps): Bump clap from 4.4.2 to 4.4.3 (#12245) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bugen Zhao <[email protected]> commit 7ca370a Author: Croxx <[email protected]> Date: Thu Sep 14 16:24:19 2023 +0800 feat(refill): fetch whole sst file when refilling (#12265) Signed-off-by: MrCroxx <[email protected]> commit ec129b6 Author: Yuhao Su <[email protected]> Date: Thu Sep 14 16:04:37 2023 +0800 chore: use cfg! to instead of #cfg[] for jemalloc control policy (#12307) commit 9814af8 Author: Runji Wang <[email protected]> Date: Thu Sep 14 14:45:14 2023 +0800 feat(expr): add `pg_sleep` function (#12294) Signed-off-by: Runji Wang <[email protected]> commit 4525e67 Author: Noel Kwan <[email protected]> Date: Thu Sep 14 14:38:03 2023 +0800 feat(stream): support source throttling (#12295) commit 5ffd58d Author: Dylan <[email protected]> Date: Thu Sep 14 14:35:03 2023 +0800 refactor(connector): replace validate source rpc with jni (#12270) commit 888f2dd Author: Eric Fu <[email protected]> Date: Thu Sep 14 14:32:59 2023 +0800 fix: panic when dumping memory profile (#12276) Signed-off-by: Little-Wallace <[email protected]>

refactor(expr): allow defining function in frontend

53b7636

Signed-off-by: TennyZhuang <[email protected]>

TennyZhuang requested review from yezizp2012, wangrunji0408 and xiangjinwu September 13, 2023 15:20

TennyZhuang requested a review from a team as a code owner September 13, 2023 15:20

github-actions bot added the type/refactor label Sep 13, 2023

TennyZhuang changed the title ~~refactor(expr): allow defining function in frontend~~ refactor(expr): allow defining functions in frontend Sep 13, 2023

github-actions bot reviewed Sep 13, 2023

View reviewed changes

src/frontend/src/expr/function/col_description.rs Outdated Show resolved Hide resolved

src/frontend/src/expr/function/mod.rs Outdated Show resolved Hide resolved

TennyZhuang and others added 2 commits September 14, 2023 00:09

Update src/frontend/src/expr/function/col_description.rs

06f81be

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/frontend/src/expr/function/mod.rs

903131d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

wangrunji0408 approved these changes Sep 13, 2023

View reviewed changes

BugenZhao reviewed Sep 14, 2023

View reviewed changes

src/frontend/src/expr/function/col_description.rs Outdated Show resolved Hide resolved

xiangjinwu approved these changes Sep 14, 2023

View reviewed changes

src/frontend/src/expr/mod.rs Outdated Show resolved Hide resolved

TennyZhuang added 6 commits September 17, 2023 21:55

Merge remote-tracking branch 'origin/main' into refactor/expr-defined…

756da85

…-in-frontend

function -> function_impl

a021d63

Signed-off-by: TennyZhuang <[email protected]>

add a comment

a53a0d0

Signed-off-by: TennyZhuang <[email protected]>

remove expr::function::window

dc18a24

Signed-off-by: TennyZhuang <[email protected]>

re-export #[function] macros in expr

e36dff3

Signed-off-by: TennyZhuang <[email protected]>

Merge branch 'main' into refactor/expr-defined-in-frontend

a069157

TennyZhuang enabled auto-merge September 18, 2023 07:26

TennyZhuang disabled auto-merge September 18, 2023 07:32

BugenZhao approved these changes Sep 18, 2023

View reviewed changes

re-export ctor

0b8fbb8

Signed-off-by: TennyZhuang <[email protected]>

TennyZhuang enabled auto-merge September 18, 2023 07:36

yezizp2012 approved these changes Sep 18, 2023

View reviewed changes

TennyZhuang added this pull request to the merge queue Sep 18, 2023

Merged via the queue into main with commit 71d8170 Sep 18, 2023
8 of 9 checks passed

TennyZhuang deleted the refactor/expr-defined-in-frontend branch September 18, 2023 08:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(expr): allow defining functions in frontend #12287

refactor(expr): allow defining functions in frontend #12287

TennyZhuang commented Sep 13, 2023

github-actions bot left a comment

wangrunji0408 left a comment

wangrunji0408 Sep 13, 2023

TennyZhuang Sep 17, 2023

wangrunji0408 Sep 18, 2023

wangrunji0408 Sep 13, 2023

wangrunji0408 Sep 13, 2023

BugenZhao left a comment

xiangjinwu left a comment

codecov bot commented Sep 18, 2023 •

edited

Loading

refactor(expr): allow defining functions in frontend #12287

refactor(expr): allow defining functions in frontend #12287

Conversation

TennyZhuang commented Sep 13, 2023

What's changed and what's your intention?

Checklist

Documentation

Release note

github-actions bot left a comment

Choose a reason for hiding this comment

wangrunji0408 left a comment

Choose a reason for hiding this comment

wangrunji0408 Sep 13, 2023

Choose a reason for hiding this comment

TennyZhuang Sep 17, 2023

Choose a reason for hiding this comment

wangrunji0408 Sep 18, 2023

Choose a reason for hiding this comment

wangrunji0408 Sep 13, 2023

Choose a reason for hiding this comment

wangrunji0408 Sep 13, 2023

Choose a reason for hiding this comment

BugenZhao left a comment

Choose a reason for hiding this comment

xiangjinwu left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 18, 2023 • edited Loading

Codecov Report

codecov bot commented Sep 18, 2023 •

edited

Loading