Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): change sink test's --max-messages parameters to --timeout-ms #12277

Closed
wants to merge 1 commit into from

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Sep 13, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

in the past, we use kafka-console-consumer.sh --max-messages to diff the Kafka's content with expected data in the test. But when the record number is less than expected, the test will hang and developer can not know the test is failed.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@st1page st1page requested a review from tabVersion September 13, 2023 09:39
@st1page st1page marked this pull request as ready for review September 13, 2023 09:43
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #12277 (2635a0f) into main (cbbee64) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #12277   +/-   ##
=======================================
  Coverage   69.72%   69.72%           
=======================================
  Files        1411     1411           
  Lines      236365   236365           
=======================================
  Hits       164807   164807           
  Misses      71558    71558           
Flag Coverage Δ
rust 69.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant