-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support privatelink.endpoint
option in the WITH clause for Kafka connector
#12266
Conversation
TODO: add support for kafka sink
privatelink_endpoint
option in the WITH of CREATE SOURCEprivatelink_endpoint
option in the WITH clause
privatelink_endpoint
option in the WITH clauseprivatelink.endpoint
option in the WITH clause
Codecov Report
@@ Coverage Diff @@
## main #12266 +/- ##
==========================================
- Coverage 69.65% 69.64% -0.01%
==========================================
Files 1424 1425 +1
Lines 236438 236492 +54
==========================================
+ Hits 164702 164716 +14
- Misses 71736 71776 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
privatelink.endpoint
option in the WITH clauseprivatelink.endpoint
option in the WITH clause for Kafka connector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
close #11397
Add
privatelink.endpoint
to the WITH clause, to support private link for Kafka connector on GCP and AWS.privatelink.endpoint
when they create a Source, Table and Sink with Kafka connector.privatelink.targets
the target ports configured on the network load balancerTested on GCP and AWS.
example usage:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Add
privatelink.endpoint
to the WITH clause, to support private link for Kafka connector on GCP and AWS.privatelink.endpoint
when they create a Source, Table and Sink with Kafka connector.privatelink.targets
the target ports configured on the network load balancer for the corresponding broker servers