Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (v1.2) ignore unrecogized/deprecated system params #12253

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Sep 13, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In case that future users of v1.2.x encounter the same problem. Not urgent.

related #12229

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh fuyufjh requested a review from yezizp2012 September 13, 2023 03:59
@github-actions github-actions bot added the type/fix Bug fix label Sep 13, 2023
@fuyufjh fuyufjh changed the title fix: port #12229: ignore unrecogized/deprecated system params fix: (v1.2) ignore unrecogized/deprecated system params Sep 13, 2023
@fuyufjh fuyufjh enabled auto-merge (squash) September 13, 2023 04:05
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v1.2-rc@0f94fdf). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 1ae3f46 differs from pull request most recent head 18312d7. Consider uploading reports for the commit 18312d7 to get more accurate results

@@            Coverage Diff             @@
##             v1.2-rc   #12253   +/-   ##
==========================================
  Coverage           ?   69.82%           
==========================================
  Files              ?     1397           
  Lines              ?   234964           
  Branches           ?        0           
==========================================
  Hits               ?   164063           
  Misses             ?    70901           
  Partials           ?        0           
Flag Coverage Δ
rust 69.82% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fuyufjh fuyufjh disabled auto-merge September 14, 2023 13:33
@fuyufjh fuyufjh enabled auto-merge (squash) September 14, 2023 13:34
@fuyufjh fuyufjh merged commit c272d3f into v1.2-rc Sep 14, 2023
2 of 3 checks passed
@fuyufjh fuyufjh deleted the eric/ignore-unrecognized-port-1.2 branch September 14, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants