Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): set correct row per second #12213

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Sep 11, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled. Otherwise rows_per_second doesn't take effect, and the actual rows_per_second is 10 by default.

After correct this, the state_cleaning_test fails: Error: Table __internal_mv_tumble_join_9_hashjoinleft_1027 has 676 rows, which is more than limit 300.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28 zwang28 requested a review from TennyZhuang September 11, 2023 15:39
@zwang28 zwang28 enabled auto-merge September 11, 2023 15:39
@github-actions github-actions bot added the type/fix Bug fix label Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #12213 (10f9ff6) into main (c9185f5) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #12213      +/-   ##
==========================================
+ Coverage   69.78%   69.79%   +0.01%     
==========================================
  Files        1408     1408              
  Lines      235754   235754              
==========================================
+ Hits       164515   164549      +34     
+ Misses      71239    71205      -34     
Flag Coverage Δ
rust 69.79% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zwang28 zwang28 requested a review from kwannoel September 12, 2023 02:31
@zwang28 zwang28 added this pull request to the merge queue Sep 12, 2023
@lmatz
Copy link
Contributor

lmatz commented Sep 12, 2023

which means we should reject unrecognized option?

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2023
@zwang28 zwang28 added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 0ef3cee Sep 12, 2023
10 of 11 checks passed
@zwang28 zwang28 deleted the wangzheng/fix_state_cleaning_test branch September 12, 2023 10:32
Li0k pushed a commit that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants